GPU accelerated rendering & Mouse-handler optimization #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeandroTreu
commented
May 17, 2024
•
LeandroTreu
commented
- Fixed issue that prevented GPU acceleration for rendering
- Further optimized mouse-handler hover computation
- Moved summarize edges setting to performance section
- Added Arrow LOD checks for deferred edges
- Replaced ellipse drawing with native call
merge master
phschaad
requested changes
May 22, 2024
src/renderer/renderer_elements.ts
Outdated
| // CanvasRenderingContext2D ellipse call as an alternative. | ||
| ctx.ellipse(x+w/2, y+h/2, w/2, h/2, 0, 0, 2 * Math.PI); | ||
|
|
||
| // const kappa = .5522848, |
There was a problem hiding this comment.
probably makes sense to remove the commented out code
src/utils/sdfv_settings.ts
Outdated
| @@ -30,7 +30,7 @@ export class SDFVSettings { | |||
| 'showStateNames': true, | |||
| 'showMapSchedules': true, | |||
| 'showDataDescriptorSizes': false, | |||
| 'summarizeLargeNumbersOfEdges': false, | |||
| 'summarizeLargeNumbersOfEdges': true, | |||
There was a problem hiding this comment.
I would prefer to leave the default on false for now since it's a very new feature that drastically changes the look of an SDFG in certain cases. It's something that people should gradually experiment with / evaluate for themselves first before we switch it to be the default.
phschaad
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.